xinbinhuang commented on a change in pull request #7795: [AIRFLOW-7104] Add
Secret backend for GCP Secrets Manager
URL: https://github.com/apache/airflow/pull/7795#discussion_r396121505
##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -40,10 +40,10 @@ class VaultSecrets(BaseSecretsBackend, LoggingMixin):
[secrets]
backend = airflow.providers.hashicorp.secrets.vault.VaultSecrets
- backend_kwargs =
{"path":"connections","url":"http://127.0.0.1:8200","mount_point":"airflow"}
+ backend_kwargs =
{"connections_path":"conns","url":"http://127.0.0.1:8200","mount_point":"airflow"}
- For example, if your keys are under ``connections`` path in ``airflow``
mount_point, this
- would be accessible if you provide ``{"path": "connections"}`` and request
+ For example, if your keys are under ``conns`` path in ``airflow``
mount_point, this
+ would be accessible if you provide ``{"connections_path": "conns"}`` and
request
conn_id ``smtp_default``.
Review comment:
May be I should have asked this before. For some reason, I was under the
impression that we can not break lines in the .cfg file. So can we break lines?
Something like this.
```
backend_kwargs =
{"connections_path":"connections","url":"http://127.0.0.1:8200","mount_point":"airflow"}
# or
backend_kwargs = {"connections_path":"connections",
"url":"http://127.0.0.1:8200";,
"mount_point":"airflow"}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
