kaxil commented on a change in pull request #7795: [AIRFLOW-7104] Add Secret
backend for GCP Secrets Manager
URL: https://github.com/apache/airflow/pull/7795#discussion_r396122238
##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -40,10 +40,10 @@ class VaultSecrets(BaseSecretsBackend, LoggingMixin):
[secrets]
backend = airflow.providers.hashicorp.secrets.vault.VaultSecrets
- backend_kwargs =
{"path":"connections","url":"http://127.0.0.1:8200","mount_point":"airflow"}
+ backend_kwargs =
{"connections_path":"conns","url":"http://127.0.0.1:8200","mount_point":"airflow"}
- For example, if your keys are under ``connections`` path in ``airflow``
mount_point, this
- would be accessible if you provide ``{"path": "connections"}`` and request
+ For example, if your keys are under ``conns`` path in ``airflow``
mount_point, this
+ would be accessible if you provide ``{"connections_path": "conns"}`` and
request
conn_id ``smtp_default``.
Review comment:
Multiline config are handled fine as long as they are indented.
Example:
```ini
[Multiline Values]
chorus: I'm a lumberjack, and I'm okay
I sleep all night and I work all-day
```
I am also fine for you to disable long-line check for this particular case
so it is easy for users to copy/paste.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
