mik-laj commented on a change in pull request #7806: Decouple DAG from DagBag and DAG from SerializedDagModel - remove cyclic imports URL: https://github.com/apache/airflow/pull/7806#discussion_r396271323
########## File path: airflow/utils/dag_cleaner.py ########## @@ -0,0 +1,288 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: Small modules with one responsibility are a better idea. https://medium.com/@severinperez/writing-flexible-code-with-the-single-responsibility-principle-b71c4f3f883f In Python, you can look at modules the same way you look at classes. This is very often interchangeable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
