mik-laj commented on a change in pull request #7806: Decouple DAG from DagBag -
remove cyclic imports
URL: https://github.com/apache/airflow/pull/7806#discussion_r396117227
##########
File path: airflow/models/dagbag.py
##########
@@ -455,5 +449,5 @@ def sync_to_db(self):
"""
Save attributes about list of DAG to the DB.
"""
- from airflow.models.dag import DAG
DAG.bulk_sync_to_db(self.dags.values())
+ SerializedDagModel.bulk_sync_to_db(self.dags.values())
Review comment:
I didn't want to add a loop to this method. In other places, we may also
need to save many items with one call, e.g. tests. I will add that the previous
code was also in the method that had the word "bulk" in the name. Bulk does not
necessarily mean that this is done with a single database query. Bulk only
means that the method accepts a list of elements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
