turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators 
for storing information from GCS into GA
URL: https://github.com/apache/airflow/pull/7743#discussion_r396984067
 
 

 ##########
 File path: airflow/providers/google/marketing_platform/hooks/analytics.py
 ##########
 @@ -30,15 +31,30 @@ class GoogleAnalyticsHook(CloudBaseHook):
     def __init__(
         self,
         api_version: str = "v3",
-        gcp_connection_id: str = "google_cloud_default",
+        gcp_conn_id: str = "google_cloud_default",
         *args,
         **kwargs
     ):
         super().__init__(*args, **kwargs)
         self.api_version = api_version
-        self.gcp_connection_is = gcp_connection_id
+        self.gcp_connection_is = gcp_conn_id
         self._conn = None
 
+    def _paginate(self, resource: Resource, list_args: Optional[Dict[str, 
Any]] = None):
+        list_args = list_args or {}
 
 Review comment:
   Because dict as mutable object should not be a default value. The `or` 
operator in this case works in the same way as ternary operator: `list_args = 
list_args if list_args is not None else {}`. The type of `list_args` is defined 
in signature : `Optional[Dict[str, Any]]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to