NBardelot commented on a change in pull request #7682: [AIRFLOW-7031] Airflow
WinRM endpoint is hardcoded to HTTP
URL: https://github.com/apache/airflow/pull/7682#discussion_r397014266
##########
File path: airflow/providers/microsoft/winrm/hooks/winrm.py
##########
@@ -199,7 +199,7 @@ def get_conn(self):
# If endpoint is not set, then build a standard wsman endpoint from
host and port.
if not self.endpoint:
- self.endpoint = 'http://{0}:{1}/wsman'.format(self.remote_host,
self.remote_port)
+ self.endpoint = '{0}://{1}:{2}/wsman'.format(self.service.lower(),
self.remote_host, self.remote_port)
Review comment:
I 100% understand what you mean, but I believe it's best to use lowercase.
The old behavious (pre-commit) was `http` lowercase. My goal is to keep the
code behaving like it did before by default, to avoid regression (uppercase
`HTTP` while RFC-compliant *is* a change in behaviour, thus it could have
unexpected side-effects for people using the hook).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
