potiuk commented on a change in pull request #7682: [AIRFLOW-7031] Airflow
WinRM endpoint is hardcoded to HTTP
URL: https://github.com/apache/airflow/pull/7682#discussion_r397128015
##########
File path: airflow/providers/microsoft/winrm/hooks/winrm.py
##########
@@ -199,7 +199,7 @@ def get_conn(self):
# If endpoint is not set, then build a standard wsman endpoint from
host and port.
if not self.endpoint:
- self.endpoint = 'http://{0}:{1}/wsman'.format(self.remote_host,
self.remote_port)
+ self.endpoint = '{0}://{1}:{2}/wsman'.format(self.service.lower(),
self.remote_host, self.remote_port)
Review comment:
Hey @ad-m -> we have no policy for that. But If you would like to propose
some - I invite you to start discussion at the devlist. This is
community-driven project and You seem to be knowledgeable in this area, I would
be very happy if someone like you could propose and discuss with the rest of
the community any proposals you might have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
