feluelle commented on a change in pull request #7903: [dont-merge] Add property
conn_name to dbapi_hook
URL: https://github.com/apache/airflow/pull/7903#discussion_r399329884
##########
File path: airflow/hooks/dbapi_hook.py
##########
@@ -61,10 +61,17 @@ def __init__(self, *args, **kwargs):
raise AirflowException("conn_name_attr is not defined")
elif len(args) == 1:
setattr(self, self.conn_name_attr, args[0])
- elif self.conn_name_attr not in kwargs:
- setattr(self, self.conn_name_attr, self.default_conn_name)
- else:
+ elif self.conn_name_attr in kwargs:
setattr(self, self.conn_name_attr, kwargs[self.conn_name_attr])
+ else:
+ setattr(self, self.conn_name_attr, self.default_conn_name)
Review comment:
```python
else:
setattr(self, self.conn_name_attr, kwargs.get(self.conn_name_attr,
self.default_conn_name)
```
instead of
```python
elif self.conn_name_attr in kwargs:
setattr(self, self.conn_name_attr, kwargs[self.conn_name_attr])
else:
setattr(self, self.conn_name_attr, self.default_conn_name)
```
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
