zhongjiajie commented on issue #7903: Add conn_name and get_connection to 
dbapi_hook
URL: https://github.com/apache/airflow/pull/7903#issuecomment-606360029
 
 
   For reviewer, in 
https://github.com/apache/airflow/pull/7903/commits/cf0a5f6fca8f219d0038c4c7ace5d98695400ce4
 I just add property `conn_name` to get `conn_name`. And then I find out we 
could change `conn = self.get_connection(self.conn_name)` to `conn = 
self.get_connection()` due to `self.conn_name` almost same in subclass of 
`DBAPI` and is no need, So I add function `get_connection` in `dbapi_hook` to 
get conn_name if no conn_id pass from subclass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to