[GitHub] [airflow] ashb opened a new pull request #8043: Use same tooltip for Graph and Tree views for TaskInstances

Wed, 01 Apr 2020 03:54:39 -0700 

ashb opened a new pull request #8043: Use same tooltip for Graph and Tree views 
for TaskInstances
URL: https://github.com/apache/airflow/pull/8043
 
 
   They had _similar_ info, but they weren't identical and should have
   been.
   
   To not include the 250kb of moment-timezone in more than one Webpack
   output bundle I changed how that is imported/handled. There may be a
   better way of doing this in webpack, but I couldn't find it, and this
   isn't horrible.
   
   
   #### Graph TI:
   
   **Before:**
   
![before_graph_ti](https://user-images.githubusercontent.com/34150/78129100-f4952280-740e-11ea-9898-df4317f8df0f.png)
   
   **After:**
   
![after_graph_ti](https://user-images.githubusercontent.com/34150/78129054-df1ff880-740e-11ea-8197-28648f2eb52c.png)
   
   (i.e. unchanged)
   
   #### Tree TI:
   **Before:**
   
![before_tree_ti](https://user-images.githubusercontent.com/34150/78129105-f6f77c80-740e-11ea-87fd-4353bf2edf5d.png)
   
   **After:**
   
![after_tree_ti](https://user-images.githubusercontent.com/34150/78129225-260dee00-740f-11ea-9e8d-2115244ea531.png)
   
   #### Tree DagRun
   
   **Before**: BROKEN ON MASTER -- no tooltip was displayed! Oops.
   
   **After:**
   
![after_tree_dagrun](https://user-images.githubusercontent.com/34150/78129055-dfb88f00-740e-11ea-9a8e-3d74ebd213cf.png)
   
   
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to