ashb commented on a change in pull request #8043: Use same tooltip for Graph
and Tree views for TaskInstances
URL: https://github.com/apache/airflow/pull/8043#discussion_r401535492
##########
File path: airflow/www/static/js/graph.js
##########
@@ -16,8 +16,8 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { generateTooltipDateTime, converAndFormatUTC, secondsToString } from
'./datetime-utils';
-import { escapeHtml } from './base';
+// global tiTooltip, taskTip
Review comment:
Global as it's included in another file that is sourced.
If I used a normal import webpack would include it in two files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services