mik-laj opened a new pull request #8157: Reorder middleware - ProxyFix and 
BaseUrl
URL: https://github.com/apache/airflow/pull/8157
 
 
   ProxyFix overrides the value of `environ["SCRIPT_NAME"]` variable, so it 
must be the first middleware.
   
   When I have setup proxy fix , setup base url (`internal-client`) and I send 
proxy headers (``"HTTP_X_FORWARDED_PREFIX": "/proxy-prefix"``). The application 
expects to be available at: ``https://valid:445/proxy-prefix/debug``
   Now correctly builds the URL: 
``https://valid:445/proxy-prefix/internal-client/debug``
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to