mik-laj commented on issue #8157: Reorder middleware - ProxyFix and BaseUrl URL: https://github.com/apache/airflow/pull/8157#issuecomment-610352293 The problem is visible in this line. https://github.com/apache/airflow/pull/8157/files#diff-a7826a115d2c9ae9009798807f329e8dR180 The following address was previously built. ``` self.assertEqual(request.url, "https://valid:445/internal-client/debug";) ``` Information from proxy headers was lost. Sometimes it needs several, because the proxy ensures that one instance can be accessed from several addresses The instance can be accessed from two addresses. For example: * `http://domain.com/team-a/` * `http://domain.com/my-airflow/` Whereas base_url makes Airflow simply available in a subdirectory. * `http://domain.com/airflow/` When we combine these two matters, we want Airflow to be available at the following addresses: * `http://domain.com/team-a/airflow/` * `http://domain.com/my-airflow/airflow/` In this PR I wanted to add missing tests for middleware, but it turned out that these proxies are not working properly and we need to change their order.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
