potiuk commented on a change in pull request #8145: Drop redundant project id
null checks.
URL: https://github.com/apache/airflow/pull/8145#discussion_r406384068
##########
File path: airflow/providers/google/cloud/hooks/stackdriver.py
##########
@@ -186,10 +186,10 @@ def enable_alert_policies(
@GoogleBaseHook.fallback_to_default_project_id
def disable_alert_policies(
self,
- project_id: Optional[str] = None,
+ project_id: str,
filter_: Optional[str] = None,
retry: Optional[str] = DEFAULT,
- timeout: Optional[str] = DEFAULT,
+ timeout: Optional[float] = DEFAULT,
Review comment:
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
