potiuk commented on a change in pull request #8145: Drop redundant project id
null checks.
URL: https://github.com/apache/airflow/pull/8145#discussion_r406381557
##########
File path: airflow/providers/google/cloud/hooks/bigtable.py
##########
@@ -54,7 +54,7 @@ def _get_client(self, project_id: str):
return self._client
@GoogleBaseHook.fallback_to_default_project_id
- def get_instance(self, instance_id: str, project_id: Optional[str] = None)
-> Instance:
+ def get_instance(self, instance_id: str, project_id: str) -> Instance:
Review comment:
Yeah. Agree. project_id: str is better IMHO. it is semantically correct - we
expect project_id to be set. And it is used most of the time below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
