potiuk commented on a change in pull request #8145: Drop redundant project id 
null checks.
URL: https://github.com/apache/airflow/pull/8145#discussion_r407034827
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/dataflow.py
 ##########
 @@ -585,10 +579,10 @@ def start_python_dataflow(  # pylint: 
disable=too-many-arguments
         variables: Dict,
         dataflow: str,
         py_options: List[str],
+        project_id: str,
 
 Review comment:
   Totally forgot about it ! It was some 1.5 year ago! Thanks @mik-laj for 
reminding :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to