jmcarp commented on a change in pull request #8145: Drop redundant project id
null checks.
URL: https://github.com/apache/airflow/pull/8145#discussion_r406995719
##########
File path: airflow/providers/google/cloud/hooks/datacatalog.py
##########
@@ -659,7 +659,7 @@ def list_tags(
location: str,
entry_group: str,
entry: str,
- page_size: int = 100,
+ page_size: Optional[int] = 100,
Review comment:
We mark this as `Optional[int]` in `CloudDataCatalogListTagsOperator`, so if
we don't also mark it as `Optional[int]` here, mypy errors:
```
airflow/providers/google/cloud/operators/datacatalog.py:1287: error:
Argument "page_size" to "list_tags" of "CloudDataCatalogHook" has incompatible
type "Optional[int]"; expected "int"
```
This is the kind of type error that mypy wasn't catching before because the
decorator on the hook method dropped type information about the method, by the
way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
