BasPH commented on a change in pull request #8257: [docs-only] Simplify language re roll-your-own secrets backend URL: https://github.com/apache/airflow/pull/8257#discussion_r407172213
########## File path: docs/howto/use-alternative-secrets-backend.rst ########## @@ -308,19 +308,14 @@ of the connection object. Roll your own secrets backend ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend`, and just has to implement the -:py:meth:`~airflow.secrets.BaseSecretsBackend.get_connections` method. +A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either Review comment: Might be worth mentioning this? What do you think? Other than that, looks good to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
