dstandish commented on a change in pull request #8257: [docs-only] Simplify language re roll-your-own secrets backend URL: https://github.com/apache/airflow/pull/8257#discussion_r407250766
########## File path: docs/howto/use-alternative-secrets-backend.rst ########## @@ -308,19 +308,14 @@ of the connection object. Roll your own secrets backend ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend`, and just has to implement the -:py:meth:`~airflow.secrets.BaseSecretsBackend.get_connections` method. +A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either Review comment: i think it's ok as is now. we have said "implement either get conn uri or get connections" -- i think that's all we really need to say here. discussion of uri format and connection model details is done elsewhere. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
