potiuk commented on a change in pull request #8383: Remove steps from travis URL: https://github.com/apache/airflow/pull/8383#discussion_r409046208
########## File path: .github/workflows/static-tests.yml ########## @@ -0,0 +1,36 @@ +name: "static tests" +on: [pull_request, push] +env: + TRAVIS_BRANCH: "master" +jobs: + statics-tests: + name: Static tests + runs-on: ubuntu-latest + env: + PYTHON_VERSION: 3.6 + AIRFLOW_MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS: "true" + TRAVIS_JOB_NAME: "Static" + strategy: + matrix: + scripts: [ci_run_static_checks_pylint_tests.sh, + ci_mypy.sh, + ci_fix_ownership.sh, Review comment: Also one more comment why this will be much, much, much slower - some of the tests (mypy, flake, pylint) require CI image to run (to keep consistent environment). If you split it to separate jobs, each of them will pull the image before running and will rebuild it with latest sources (to make sure they are using latest setup.py for tests). When you run mypy + flake + pylint in a single pre-commit run, they will all download the image and potentially build the image with the latest setup.py - this adds even more "per-job" overhead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
