potiuk commented on a change in pull request #8383: Remove steps from travis URL: https://github.com/apache/airflow/pull/8383#discussion_r409059284
########## File path: .github/workflows/static-tests.yml ########## @@ -0,0 +1,36 @@ +name: "static tests" +on: [pull_request, push] +env: + TRAVIS_BRANCH: "master" +jobs: + statics-tests: + name: Static tests + runs-on: ubuntu-latest + env: + PYTHON_VERSION: 3.6 + AIRFLOW_MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS: "true" + TRAVIS_JOB_NAME: "Static" + strategy: + matrix: + scripts: [ci_run_static_checks_pylint_tests.sh, + ci_mypy.sh, + ci_fix_ownership.sh, Review comment: I think what can help better is to keep most of the checks together but to get rid of the --verbose flag. The flag was introduced to see time of execution of each step. But... it's not needed any more in GA - in GA you can click the checkbox and see the timestamp for each line of the log. Once you disable the --verbose flag, it is much more obvious which step is failing because you will see a wall of green 'Passed" broken by some "Failed" (the output of each command is hidden if the result is "Passed"). This will be much better approach. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
