kaxil commented on a change in pull request #8487:
URL: https://github.com/apache/airflow/pull/8487#discussion_r412159392
##########
File path: setup.py
##########
@@ -446,6 +446,9 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
'pytest',
'pytest-cov',
'pytest-instafail',
+ 'pytest-rerunfailures',
Review comment:
It is difficult to justify why we are adding this new requirement if it
is not being used.
For example, if we won't add a new operator and we split it into 2: (1) Adds
required libraries (2) Adds the actual operator, it wouldn't be as readable I
think
A single PR that says "This is the change we need" (dependency is just
something we need for that change).
Happy to hear what others think.
I think that particular comment from @turbaszek was because botocore change
was not related to that PR so I understand his concern and I feel the same but
here both would be related. (please correct me if I have mis-interpreted you,
@tomek)
I am happy either way but happy to hear thoughts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
