potiuk commented on a change in pull request #8487:
URL: https://github.com/apache/airflow/pull/8487#discussion_r412166879
##########
File path: setup.py
##########
@@ -446,6 +446,9 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
'pytest',
'pytest-cov',
'pytest-instafail',
+ 'pytest-rerunfailures',
Review comment:
One thing that is important here. Right now when we change setup.py and
you generate requirements.txt files also "unrelated" libraries will get bump (i
am using eager update strategy). This is so that the requirements get bumped to
reflect what a "new user" will get when the user runs "pip install airflow"
(note that those are not real "requirements" - those are constraint files and
their meaning is "those are the set of requirements that we know will work").
So always when you update setup.py (and only then) you will get as result a
bunch of changes to unrelated library versions - we use so many libraries that
pretty much every day some library will get released). Now this is good that we
have it (this way we can keep being updated with "new user" experience of
airflow installation (and fix potential problems early). But then really the
"requirements" updates are now connected with "setup.py" changes. and not with
the actual functionality using it.
So we have two options now:
1) Treat "setup.py" updates as an opportunity to bump constraint files and
have it a separate commit/PR
2) Merge it all together - including code changes related to the new
requirement with unrelated constraint upgrades
I think 1) is a bit cleaner...
We can also think about
3) split unrelated constraint upgrades to separate commit - but I think this
is much worse than 1) or 2)
@turbaszek @dimberman @ashb @mik-laj Others?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
