ashb commented on a change in pull request #8807:
URL: https://github.com/apache/airflow/pull/8807#discussion_r423012819



##########
File path: scripts/ci/_utils.sh
##########
@@ -1653,6 +1654,27 @@ function run_prepare_packages() {
         | tee -a "${OUTPUT_LOG}"
 }
 
+# Docker command to generate release notes for backport packages
+function run_generate_readme() {

Review comment:
       This is only used from `scripts/ci/ci_generate_backport_readme.sh` 
right? If so I'd like it to live there, otherwise it makes it much harder to 
see what each script does when the bulk of it's job is calling a (non-reused) 
function in another file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to