ashb commented on a change in pull request #8807:
URL: https://github.com/apache/airflow/pull/8807#discussion_r423014262
##########
File path: tests/bats/test_local_mounts.bats
##########
@@ -56,6 +56,8 @@ ${AIRFLOW_SOURCES}/NOTICE:/opt/airflow/NOTICE:cached
-v
${AIRFLOW_SOURCES}/airflow:/opt/airflow/airflow:cached
-v
+${AIRFLOW_SOURCES}/backport_packages/setup_backport_packages.py:/opt/airflow/backport_packages/setup_backport_packages.py:cached
Review comment:
Off topic to this PR, but this test seems quite low value to me -- we
just have to keep the list in sync in two places. A generic test to check the
behavour of convert_local_mounts_to_docker_params I'm cool with, but having to
update this test just when we add a new list: not so much. I don't see what it
buys us?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
