j-y-matsubara commented on a change in pull request #8867:
URL: https://github.com/apache/airflow/pull/8867#discussion_r427747575
##########
File path: airflow/sensors/base_sensor_operator.py
##########
@@ -70,6 +72,7 @@ def __init__(self,
timeout: float = 60 * 60 * 24 * 7,
soft_fail: bool = False,
mode: str = 'poke',
+ downstream_skip=None,
Review comment:
@yuqian90
This is because the default behavior is different when soft_fail is not set
/ set False or when soft_fail=True.
When setting `soft_fail = True` , All downstream tasks are skipped forcibly.
When setting `soft_fail = False`, All downstream tasks are not skipped
forcibly.
However, I will fix it according to your opinion.
>The original behaviour is to just raise AirflowSensorTimeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
