mustafagok commented on a change in pull request #8888:
URL: https://github.com/apache/airflow/pull/8888#discussion_r429553900
##########
File path: airflow/providers/amazon/aws/example_dags/example_ecs_fargate.py
##########
@@ -64,8 +65,8 @@
},
network_configuration={
"awsvpcConfiguration": {
- "securityGroups": ["sg-123abc"],
- "subnets": ["subnet-123456ab"],
+ "securityGroups": [os.environ.get("SECURITY_GROUP_ID")], # or
simply ["sg-123abc"],
+ "subnets": [os.environ.get("SUBNET_ID")], # or simply
["subnet-123456ab"],
Review comment:
these are example (placeholder) values, because this is example dag. I
just want to show that the reader can use hard-coded values. Also, at the same
time the example dag can be used in system tests. I can change as you suggest
but the "fallback values" are not going to work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
