mustafagok commented on a change in pull request #8888:
URL: https://github.com/apache/airflow/pull/8888#discussion_r429554235
##########
File path: tests/test_utils/amazon_system_helpers.py
##########
@@ -60,6 +84,25 @@ def execute_with_ctx(cls, cmd: List[str]):
with provide_aws_context():
executor.execute_cmd(cmd=cmd)
+ @staticmethod
+ def create_connection(aws_conn_id: str,
+ region: str = "eu-west-1") -> None:
Review comment:
I defined default values but not used, user have to define environment
variable. You can check PR description and the docstring of ECSSystemTest
class. also line 62, 80 and 113 in the
airflow/tests/providers/amazon/aws/operators/test_ecs_system.py file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
