KevinYang21 commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-633339433


   Would probly be helpful to include an architecture diagram for it. Since a 
couple other folks are intereseted, maybe you can share a high level number on 
the impact this change has done inside Airbnb?
   
   I'm +1 for the current implementation that controls the behavior through 
configuration. A couple question:
   1. How would smart sensor cover more operator types other than the two 
included in this PR?
   1. The `poke_context` seems to be serialized as JSON. Does it align with how 
we serialize DAGs in the DAG serialization project?( I think that's also using 
JSON but want to check if there's anything that we can reuse or combine). CC: 
@cong-zhu to comment on DAG serialization


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to