ashb commented on a change in pull request #8227:
URL: https://github.com/apache/airflow/pull/8227#discussion_r432152810
##########
File path: airflow/models/dag.py
##########
@@ -1468,14 +1472,28 @@ def create_dagrun(self,
:param session: database session
:type session: sqlalchemy.orm.session.Session
"""
+ if run_id:
Review comment:
```suggestion
if run_id and not run_type:
```
We should be able to specify a type and an run_id, don't you think? (Right
now this would blindly overwrite the provided run_type if run_id is specified.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
