ashb commented on a change in pull request #8227:
URL: https://github.com/apache/airflow/pull/8227#discussion_r434621791
##########
File path: airflow/www/views.py
##########
@@ -2493,8 +2492,8 @@ class DagRunModelView(AirflowModelView):
base_permissions = ['can_list', 'can_add']
add_columns = ['state', 'dag_id', 'execution_date', 'run_id',
'external_trigger', 'conf']
- list_columns = ['state', 'dag_id', 'execution_date', 'run_id',
'external_trigger', 'conf']
- search_columns = ['state', 'dag_id', 'execution_date', 'run_id',
'external_trigger', 'conf']
+ list_columns = ['state', 'dag_id', 'execution_date', 'run_id',
'external_trigger', 'conf', 'run_type']
+ search_columns = ['state', 'dag_id', 'execution_date', 'run_id',
'external_trigger', 'conf', 'run_type']
Review comment:
Since this is the order the columns are displayed in the UI I think this
would be a more useful order
```suggestion
list_columns = ['state', 'dag_id', 'execution_date', 'run_id',
'run_type', 'external_trigger', 'conf']
search_columns = ['state', 'dag_id', 'execution_date', 'run_id',
'run_type', 'external_trigger', 'conf']
```
(specifically before the possibly quite unwieldy conf.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
