turbaszek commented on issue #9009: URL: https://github.com/apache/airflow/issues/9009#issuecomment-638355905
> So what I have in mind is that the `def setUpClass` automatically `terraform init` and `apply`s the infra located in `tests/providers/*/infrastructure` for a file named as the example dag file and should end with `.tf` **if exists** I like this idea! > > Is creating a single GCS bucket worth adding terraform? > > @turbaszek in my opinion we should do it consistenly for all example_dags. Do you think it would be slow or just superfluous? Or what is your concern? My main concern is that normally I would never use terraform to create single bucket. But it's not a strong opinion. I'm in favor of unified and opinionated approach 👌 > I think the biggest plus is that the infra automatically gets destroyed so we do not accidently let something exists longer as the test needs it. Theoretically `tearDown` should always be executed so currently all infrastructure should also be destroyed. However, the advantage of using `.tf` is that everything we defined will be created and destroyed, so no place for discrepancies between setUp and tearDown. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
