[ 
https://issues.apache.org/jira/browse/AIRFLOW-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126605#comment-17126605
 ] 

ASF GitHub Bot commented on AIRFLOW-7014:
-----------------------------------------

ephraimbuddy commented on a change in pull request #9149:
URL: https://github.com/apache/airflow/pull/9149#discussion_r435818662



##########
File path: airflow/providers/apache/kylin/hooks/kylin.py
##########
@@ -0,0 +1,66 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.exceptions import AirflowException
+from airflow.hooks.base_hook import BaseHook
+from kylinpy import kylinpy
+from kylinpy import exceptions
+
+
+class KylinHook(BaseHook):
+    """
+    :param kylin_conn_id: The connection id as configured in Airflow 
administration.
+    :type kylin_conn_id: str
+    :param project: porject name
+    :type project: str
+    :param dsn: dsn
+    :type dsn: str
+    """
+    def __init__(self,
+                 kylin_conn_id='kylin_default',
+                 project=None,
+                 dsn=None,

Review comment:
       ```suggestion
                    kylin_conn_id: Optional[str]='kylin_default',
                    project: Optional[str]=None,
                    dsn: Optional[str]=None,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Operator for Apache Kylin 
> --------------------------
>
>                 Key: AIRFLOW-7014
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-7014
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: executors, operators
>    Affects Versions: 1.10.0
>            Reporter: Shao Feng Shi
>            Assignee: liuyongheng
>            Priority: Major
>
> Apache Kylin is an analytial data warehouse for big data. Kylin provides a 
> set of RESTful API for user to trigger the data loading, and also run SQL 
> queries against the OLAP cubes in sub-seconds latency. We developed a 
> KylinOperator within Airflow, so that user can easily trigger Kylin with 
> other tasks (hive, spark, etc), and plan to contribute into Airflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to