mik-laj opened a new pull request #9223:
URL: https://github.com/apache/airflow/pull/9223


   NOTE TO REVIEWERS. This commit is based on 
https://github.com/apache/airflow/pull/9219 so please review only last commit.
   
   I wanted to present a generic wrapper for CLI tools that uses only one 
binary file. It's a multi-call binary.  A multi-call binary is an executable 
program that performs the same job as more than one utility program. That means 
there is just a single binary, but that single binary acts like a large number 
of wrappers. This makes the code easier to maintain because it doesn't have 
duplicate code. In the previous implementation, the common parts between 
wrappers were duplicated. For me, the most important thing is that we generate 
scripts that generate other scripts. This approach prevents code analysis by 
static code analysis tools and error-prone. It's very easy to forget to add an 
escape character.
   
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Target Github ISSUE in description if exists
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to