ashb commented on a change in pull request #9332:
URL: https://github.com/apache/airflow/pull/9332#discussion_r440949165
##########
File path: kubernetes_tests/test_kubernetes_pod_operator.py
##########
@@ -804,27 +730,27 @@ def test_pod_priority_class_name(
priority_class_name=priority_class_name,
)
- monitor_mock.return_value = (State.SUCCESS, None)
+ run_mock.return_value = (State.SUCCESS, None)
context = create_context(k)
k.execute(context)
actual_pod = self.api_client.sanitize_for_serialization(k.pod)
self.expected_pod['spec']['priorityClassName'] = priority_class_name
self.assertEqual(self.expected_pod, actual_pod)
- def test_pod_name(self):
- pod_name_too_long = "a" * 221
- with self.assertRaises(AirflowException):
- KubernetesPodOperator(
- namespace='default',
- image="ubuntu:16.04",
- cmds=["bash", "-cx"],
- arguments=["echo 10"],
- labels={"foo": "bar"},
- name=pod_name_too_long,
- task_id="task",
- in_cluster=False,
- do_xcom_push=False,
- )
+ # def test_pod_name(self):
+ # pod_name_too_long = "a" * 221
+ # with self.assertRaises(AirflowException):
+ # KubernetesPodOperator(
+ # namespace='default',
+ # image="ubuntu:16.04",
+ # cmds=["bash", "-cx"],
+ # arguments=["echo 10"],
+ # labels={"foo": "bar"},
+ # name=pod_name_too_long,
+ # task_id="task",
+ # in_cluster=False,
+ # do_xcom_push=False,
+ # )
Review comment:
Delete if not needed (rather than leave commented out)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
