ashb commented on a change in pull request #9332:
URL: https://github.com/apache/airflow/pull/9332#discussion_r441119939
##########
File path: scripts/ci/libraries/_kind.sh
##########
@@ -329,25 +329,25 @@ function prepare_kubernetes_resources() {
sed -e "/{{INIT_GIT_SYNC}}/{r
${TEMPLATE_DIRNAME}/init_git_sync.template.yaml" -e 'd}' \
"${TEMPLATE_DIRNAME}/airflow.template.yaml"
>"${BUILD_DIRNAME}/airflow.yaml"
fi
- sed -i "s|{{AIRFLOW_KUBERNETES_IMAGE}}|${AIRFLOW_KUBERNETES_IMAGE}|g"
"${BUILD_DIRNAME}/airflow.yaml"
+ sed -i '' "s|{{AIRFLOW_KUBERNETES_IMAGE}}|${AIRFLOW_KUBERNETES_IMAGE}|g"
"${BUILD_DIRNAME}/airflow.yaml"
- sed -i "s|{{CONFIGMAP_GIT_REPO}}|${CONFIGMAP_GIT_REPO}|g"
"${BUILD_DIRNAME}/airflow.yaml"
- sed -i "s|{{CONFIGMAP_BRANCH}}|${CONFIGMAP_BRANCH}|g"
"${BUILD_DIRNAME}/airflow.yaml"
- sed -i "s|{{INIT_DAGS_VOLUME_NAME}}|${INIT_DAGS_VOLUME_NAME}|g"
"${BUILD_DIRNAME}/airflow.yaml"
- sed -i
"s|{{POD_AIRFLOW_DAGS_VOLUME_NAME}}|${POD_AIRFLOW_DAGS_VOLUME_NAME}|g" \
+ sed -i '' "s|{{CONFIGMAP_GIT_REPO}}|${CONFIGMAP_GIT_REPO}|g"
"${BUILD_DIRNAME}/airflow.yaml"
+ sed -i '' "s|{{CONFIGMAP_BRANCH}}|${CONFIGMAP_BRANCH}|g"
"${BUILD_DIRNAME}/airflow.yaml"
+ sed -i '' "s|{{INIT_DAGS_VOLUME_NAME}}|${INIT_DAGS_VOLUME_NAME}|g"
"${BUILD_DIRNAME}/airflow.yaml"
+ sed -i ''
"s|{{POD_AIRFLOW_DAGS_VOLUME_NAME}}|${POD_AIRFLOW_DAGS_VOLUME_NAME}|g" \
Review comment:
This should probably be a change on master first/as well. (gsed vs osx
sed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
