OmairK commented on a change in pull request #9473:
URL: https://github.com/apache/airflow/pull/9473#discussion_r444302962
##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -14,23 +14,28 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from flask import request
+from connexion import NoContent
+from sqlalchemy import and_, func
-from sqlalchemy import func
-
-from airflow.api_connexion.exceptions import NotFound
+from airflow.api_connexion.exceptions import NotFound, AlreadyExists
from airflow.api_connexion.schemas.dag_run_schema import (
DAGRunCollection, dagrun_collection_schema, dagrun_schema,
)
from airflow.api_connexion.utils import conn_parse_datetime
-from airflow.models import DagRun
+from airflow.models import DagRun, DagModel
from airflow.utils.session import provide_session
+from airflow.utils.types import DagRunType
-def delete_dag_run():
+@provide_session
+def delete_dag_run(dag_id, dag_run_id, session):
"""
Delete a DAG Run
"""
- raise NotImplementedError("Not implemented yet.")
+ if session.query(DagRun).filter(and_(DagRun.dag_id == dag_id,
DagRun.run_id == dag_run_id)).delete() == 0:
+ raise NotFound("DAGRun not found")
Review comment:
Thanks fixed `5e70d02 `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
