OmairK commented on a change in pull request #9473:
URL: https://github.com/apache/airflow/pull/9473#discussion_r444311320
##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -76,10 +78,18 @@ def _create_test_dag_run(self, state='running',
extra_dag=False):
class TestDeleteDagRun(TestDagRunEndpoint):
- @pytest.mark.skip(reason="Not implemented yet")
- def test_should_response_200(self):
- response =
self.client.delete("api/v1/dags/TEST_DAG_ID}/dagRuns/TEST_DAG_RUN_ID")
+ @provide_session
+ def test_should_response_200(self, session):
+ session.add_all(self._create_test_dag_run())
+ session.commit()
+ response =
self.client.delete("api/v1/dags/TEST_DAG_ID/dagRuns/TEST_DAG_RUN_ID_1")
assert response.status_code == 204
+ response =
self.client.get("api/v1/dags/TEST_DAG_ID/dagRuns/TEST_DAG_RUN_ID_1")
+ self.assertEqual(response.status_code, 404)
+
+ def test_should_response_404(self):
+ response =
self.client.delete("api/v1/dags/INVALID_DAG_RUN/dagRuns/INVALID_DAG_RUN")
+ self.assertEqual(response.status_code, 404)
Review comment:
Fixed thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
