mik-laj commented on a change in pull request #9431:
URL: https://github.com/apache/airflow/pull/9431#discussion_r444567648
##########
File path: airflow/api_connexion/parameters.py
##########
@@ -20,11 +20,11 @@
from pendulum.parsing import ParserError
from airflow.api_connexion.exceptions import BadRequest
+from airflow.configuration import conf
from airflow.utils import timezone
-# Page parameters
-page_offset = "offset"
-page_limit = "limit"
+MAXIMUM_PAGE_LIMIT = 1000
Review comment:
Why is there a hard limit in the code? I think we can trust the user
that he will not configure the limit incorrectly. I am able to imagine
situations that this limit may be insufficient if the user wants to migrate
data from one instance to another.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
