ephraimbuddy commented on a change in pull request #9431:
URL: https://github.com/apache/airflow/pull/9431#discussion_r444678716
##########
File path: airflow/api_connexion/parameters.py
##########
@@ -48,6 +49,22 @@ def format_datetime(value: str):
)
+def check_limit(value: int):
+ """
+ This checks the limit passed to view and raises BadRequest if
+ limit exceed user configured value
+ """
+ max_val = conf.getint("api", "maximum_page_limit") # user configured page
limit
Review comment:
I tried having the default only on the config but it turned out that
limit doesn't get parsed to views. It was giving some unexpected behaviours.
But as it is now, it's giving us exactly as described.
I will also try again if I can have it solely on the config without the one
on spec
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
