timhealz commented on a change in pull request #8849:
URL: https://github.com/apache/airflow/pull/8849#discussion_r453347245
##########
File path: tests/providers/google/cloud/operators/test_local_to_gcs.py
##########
@@ -42,15 +44,24 @@ def setUp(self):
'start_date': datetime.datetime(2017, 1, 1)
}
self.dag = DAG('test_dag_id', default_args=args)
+ self.testfile1 = tempfile.NamedTemporaryFile(delete=False)
+ self.testfile1.write(b"x" * 393216)
+ self.testfile1.flush()
+ self.testfile2 = tempfile.NamedTemporaryFile(delete=False)
+ self.testfile2.write(b"x" * 393216)
+ self.testfile2.flush()
+ self.testfiles = [self.testfile1.name, self.testfile2.name]
Review comment:
These are created in `/tmp` directory so I I figure they would be ok per
earlier feedback. Looks like the tests are passing now.
However, I realized that physical files aren't even needed in the tests so
I'm going to try with dummy files as strings instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
