timhealz commented on a change in pull request #8849:
URL: https://github.com/apache/airflow/pull/8849#discussion_r453433507
##########
File path: tests/providers/google/cloud/operators/test_local_to_gcs.py
##########
@@ -42,15 +44,24 @@ def setUp(self):
'start_date': datetime.datetime(2017, 1, 1)
}
self.dag = DAG('test_dag_id', default_args=args)
+ self.testfile1 = tempfile.NamedTemporaryFile(delete=False)
+ self.testfile1.write(b"x" * 393216)
+ self.testfile1.flush()
+ self.testfile2 = tempfile.NamedTemporaryFile(delete=False)
+ self.testfile2.write(b"x" * 393216)
+ self.testfile2.flush()
+ self.testfiles = [self.testfile1.name, self.testfile2.name]
Review comment:
Actually, we can't use dummy files as strings since this now uses glob.
We need to be able to test glob functionality with actual files. To
accommodate, I've added a `tearDown` method to the tests to remove the files
once the tests are completed.
I've also changed back to manually created named files so the wildcard
searches can return more consistent results.
Sorry the confusion, this is now passing all the checks and ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
