ashb commented on pull request #9008:
URL: https://github.com/apache/airflow/pull/9008#issuecomment-659324861
The way this is implemented is far to specialized, and hacky.
They way I would expect this to work:
- We first try to get the named secret -- if that finds a valid secret then
we use the existing conn_uri approach; otherwise
- We list secrets under the named path (i.e.
`List("/airflow/connections/my_conn_id")` and then we fetch each of those
secrets, feeding them in to a `Connection()` call in some manner.
This way we an support arbitrary extra parameters, i.e. the all the extra
params for a Connection too, and we don't ever need to use `ast`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
