liuandy commented on a change in pull request #9843:
URL: https://github.com/apache/airflow/pull/9843#discussion_r456192285
##########
File path: tests/models/test_connection.py
##########
@@ -533,3 +534,7 @@ def test_enforce_alphabetical_order(self):
expected_keys = sorted(current_keys)
self.assertEqual(expected_keys, current_keys)
+
+ def test_hooks_importable(self):
+ for conn_type in CONN_TYPE_TO_HOOK:
+
self.assertTrue(issubclass(import_string(CONN_TYPE_TO_HOOK[conn_type][0]),
BaseHook))
Review comment:
LGTM. This is much cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]