mik-laj commented on a change in pull request #9874:
URL: https://github.com/apache/airflow/pull/9874#discussion_r456829290
##########
File path: tests/providers/apache/cassandra/sensors/test_record.py
##########
@@ -21,15 +21,38 @@
from airflow.providers.apache.cassandra.sensors.record import
CassandraRecordSensor
+TEST_CASSANDRA_CONN_ID = 'cassandra_default'
+TEST_CASSANDRA_TABLE = 't'
+TEST_CASSANDRA_KEY = {'foo': 'bar'}
+
class TestCassandraRecordSensor(unittest.TestCase):
@patch("airflow.providers.apache.cassandra.sensors.record.CassandraHook")
def test_poke(self, mock_hook):
sensor = CassandraRecordSensor(
task_id='test_task',
- cassandra_conn_id='cassandra_default',
- table='t',
- keys={'foo': 'bar'}
+ cassandra_conn_id=TEST_CASSANDRA_CONN_ID,
+ table=TEST_CASSANDRA_TABLE,
+ keys=TEST_CASSANDRA_KEY,
+ )
+ exists = sensor.poke(dict())
+
+ self.assertTrue(exists)
+
+
mock_hook.return_value.record_exists.assert_called_once_with(TEST_CASSANDRA_TABLE,
TEST_CASSANDRA_KEY)
+ mock_hook.assert_called_once_with(TEST_CASSANDRA_CONN_ID)
+
+ @patch("airflow.providers.apache.cassandra.sensors.record.CassandraHook")
+ def test_poke_should_not_fail_with_empty_keys(self, mock_hook):
+ sensor = CassandraRecordSensor(
+ task_id='test_task',
+ cassandra_conn_id=TEST_CASSANDRA_CONN_ID,
+ table=TEST_CASSANDRA_TABLE,
+ keys=None,
)
- sensor.poke(None)
- mock_hook.return_value.record_exists.assert_called_once_with('t',
{'foo': 'bar'})
+ exists = sensor.poke(dict())
+
+ self.assertTrue(exists)
Review comment:
Can you add a test that will check False?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
