dimberman commented on a change in pull request #9903:
URL: https://github.com/apache/airflow/pull/9903#discussion_r458193865
##########
File path: airflow/config_templates/config.yml
##########
@@ -2173,6 +2173,13 @@
type: string
example: ~
default: ""
+ - name: pod_mutation_using_k8s_pod
Review comment:
@kaxil I tried to figure that out but... here's where it gets tricky.
We now need to determine what type to send INTO the pod_mutation_hook
function. If a user is using an existing pod_mutation_hook Pod object, then
they need to RECIEVE the Pod instead of a Kubernetes V1Pod otherwise the
function will break. Does that make sense? If this were a typed language we'd
need BOTH of these functions
```
def pod_mutation_hook(pod: k8s.V1Pod) -> k8s.V1Pod
```
AND
```
def pod_mutation_hook(pod: airflow.kubernetes.pod.Pod) ->
airflow.kubernetes.pod.Pod
```
I'm not sure how to handle that other than setting a flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
