kaxil commented on a change in pull request #9903:
URL: https://github.com/apache/airflow/pull/9903#discussion_r458201952
##########
File path: airflow/config_templates/config.yml
##########
@@ -2173,6 +2173,13 @@
type: string
example: ~
default: ""
+ - name: pod_mutation_using_k8s_pod
Review comment:
But based on the following can we not send the type that we receive?
```
if isinstance(k8s.V1Pod):
# Use Pod from k8s API
pod_mutation_hook(pod)
....
else:
# Use Pod from Airflow POD
pod_mutation_hook(pod)
```
If it is just for TypeHints, we can avoid typehints as Python2.7 does not
work with it or use `Union[k8s.V1Pod, airflow.kubernetes.pod.Pod]`
```
def pod_mutation_hook(pod: Union[k8s.V1Pod, airflow.kubernetes.pod.Pod]) ->
Union[k8s.V1Pod, airflow.kubernetes.pod.Pod]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
