YingboWang commented on a change in pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#discussion_r459801503
##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -35,6 +36,9 @@
from airflow.utils.log.json_formatter import JSONFormatter
from airflow.utils.log.logging_mixin import LoggingMixin
+# Elasticsearch hosted log type
+EsLogMsgType = List[Tuple[str, str]]
Review comment:
Since the execution of one task instance will be processed in two steps,
the logs generated from these two steps might come from different host. In
es_task_handler, the logs are fetched by offset and it could mess up logs from
two hosts. The change in here is to change the returning logs from string to a
list of hosted log string so that users can have a readable log url.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
