mik-laj commented on a change in pull request #9969:
URL: https://github.com/apache/airflow/pull/9969#discussion_r460221694
##########
File path: airflow/providers/amazon/aws/hooks/emr.py
##########
@@ -65,7 +71,7 @@ def get_cluster_id_by_name(self, emr_cluster_name,
cluster_states):
self.log.info('No cluster found for name %s', emr_cluster_name)
return None
- def create_job_flow(self, job_flow_overrides):
+ def create_job_flow(self, job_flow_overrides) -> Dict[str, Any]:
Review comment:
```suggestion
def create_job_flow(self, job_flow_overrides: Dict[str, Any]) ->
Dict[str, Any]:
```
##########
File path: airflow/providers/amazon/aws/operators/emr_add_steps.py
##########
@@ -69,13 +70,14 @@ def __init__(
self.cluster_states = cluster_states
self.steps = steps
- def execute(self, context):
+ def execute(self, context) -> List[str]:
Review comment:
```suggestion
def execute(self, context: Dict[str, Any]) -> List[str]:
```
##########
File path: airflow/providers/amazon/aws/operators/emr_create_job_flow.py
##########
@@ -57,7 +58,7 @@ def __init__(
self.job_flow_overrides = job_flow_overrides
self.region_name = region_name
- def execute(self, context):
+ def execute(self, context) -> str:
Review comment:
```suggestion
def execute(self, context: Dict[str, Any]) -> str:
```
##########
File path: airflow/providers/amazon/aws/operators/emr_modify_cluster.py
##########
@@ -51,7 +51,7 @@ def __init__(
self.cluster_id = cluster_id
self.step_concurrency_level = step_concurrency_level
- def execute(self, context):
+ def execute(self, context) -> int:
Review comment:
```suggestion
def execute(self, context: Dict[str, Any]) -> int:
```
##########
File path: airflow/providers/amazon/aws/operators/emr_terminate_job_flow.py
##########
@@ -37,14 +37,14 @@ class EmrTerminateJobFlowOperator(BaseOperator):
@apply_defaults
def __init__(
self,
- job_flow_id,
- aws_conn_id='aws_default',
+ job_flow_id: str,
+ aws_conn_id: str = 'aws_default',
*args, **kwargs):
super().__init__(*args, **kwargs)
self.job_flow_id = job_flow_id
self.aws_conn_id = aws_conn_id
- def execute(self, context):
+ def execute(self, context) -> None:
Review comment:
```suggestion
def execute(self, context: Dict[str, Any]) -> None:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
