ipeluffo commented on a change in pull request #9969:
URL: https://github.com/apache/airflow/pull/9969#discussion_r460581973
##########
File path: airflow/providers/amazon/aws/hooks/emr.py
##########
@@ -36,7 +38,11 @@ def __init__(self, emr_conn_id=None, *args, **kwargs):
self.emr_conn_id = emr_conn_id
super().__init__(client_type='emr', *args, **kwargs)
- def get_cluster_id_by_name(self, emr_cluster_name, cluster_states):
+ def get_cluster_id_by_name(
+ self,
+ emr_cluster_name: str,
+ cluster_states: Optional[List[str]]
Review comment:
Probably this should be:
```python
cluster_states: List[str]
```
However, if it's really optional, then the correct use would be (keep in
mind this would change the original function's signature):
```python
cluster_states: Optional[List[str]] = None
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
